Remove DacDbi GetAppDomainObject API from native and cDAC#127673
Merged
barosiak merged 3 commits intodotnet:mainfrom May 2, 2026
Merged
Remove DacDbi GetAppDomainObject API from native and cDAC#127673barosiak merged 3 commits intodotnet:mainfrom
barosiak merged 3 commits intodotnet:mainfrom
Conversation
Contributor
|
Tagging subscribers to this area: @steveisok, @tommcdon, @dotnet/dotnet-diag |
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the unused GetAppDomainObject API across the DAC/DBI native COM contract and the legacy managed cDAC projection, since the underlying GetRawExposedObjectHandleForDebugger() always returned NULL and the right-side API effectively always returned S_FALSE.
Changes:
- Deleted
GetAppDomainObjectfrom theIDacDbiInterfacecontract (IDL + native abstract interface + native implementation). - Removed the legacy managed cDAC projection/forwarder for
GetAppDomainObject. - Simplified
CordbAppDomain::GetObjectnow that the underlying DAC query path is gone.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/IDacDbiInterface.cs | Removes the managed COM projection method for GetAppDomainObject. |
| src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/DacDbiImpl.cs | Removes legacy-fallback forwarding implementation for GetAppDomainObject. |
| src/coreclr/vm/appdomain.hpp | Removes AppDomain::GetRawExposedObjectHandleForDebugger() (sole consumer of the removed DAC API). |
| src/coreclr/inc/dacdbi.idl | Removes GetAppDomainObject from the COM IDL contract. |
| src/coreclr/debug/inc/dacdbiinterface.h | Removes GetAppDomainObject from the native abstract interface definition/docs. |
| src/coreclr/debug/di/rsappdomain.cpp | Simplifies CordbAppDomain::GetObject to always return S_FALSE/null. |
| src/coreclr/debug/daccess/dacdbiimpl.h | Removes GetAppDomainObject declaration from DAC implementation class. |
| src/coreclr/debug/daccess/dacdbiimpl.cpp | Removes GetAppDomainObject implementation from the DAC. |
rcj1
approved these changes
May 1, 2026
noahfalk
approved these changes
May 1, 2026
hoyosjs
approved these changes
May 2, 2026
Member
|
/ba-g Scheduler issue for NAOT win-x64 debug. Leg isn't affected by this change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GetRawExposedObjectHandleForDebugger() always returned NULL, making GetAppDomainObject a no-op.
This pr removes it from all layers: